Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tar to UBI base image so it works with kubectl cp #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tar to UBI base image so it works with kubectl cp #67

wants to merge 1 commit into from

Conversation

tnozicka
Copy link
Member

kubectl cp requires tar binary in the target image so we need to include it in the UBI base image used as a runtime.

Resolves #66

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. labels Sep 18, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@tnozicka tnozicka mentioned this pull request Sep 18, 2024
Open
1 task
@tnozicka tnozicka changed the title Add tar to UBi base iamge so it works with kubectl cp Add tar to UBi base image so it works with kubectl cp Sep 18, 2024
@tnozicka tnozicka changed the title Add tar to UBi base image so it works with kubectl cp Add tar to UBI base image so it works with kubectl cp Sep 18, 2024
zimnx
zimnx approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Copy link
Collaborator

zimnx commented Sep 19, 2024 •
edited
Loading

Looks like it still gets stuck on building arm64 (twice in a row) :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UBI base image is missing tar package
2 participants
@tnozicka @zimnx