Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch runtime image to the new UBI base image #2121

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Sep 18, 2024

Description of your changes:
We have stopped building Ubuntu base images in scylladb/scylla-operator-images#54 and replaced the with UBI. This PR follows up on that effort and switches the runtime image to UBI.

Which issue is resolved by this Pull Request:
Resolves #1192

fyi @ylebi

Requires

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Sep 18, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@tnozicka tnozicka changed the title [WIP] Update Golang to 1.23 and use the new UBI runtime image [WIP] Switch runtime image to the new UBI base image Sep 18, 2024
@tnozicka
Copy link
Member Author

blocked on scylladb/scylla-operator-images#66

@tnozicka
Copy link
Member Author

tnozicka commented Oct 2, 2024

/retest

@tnozicka
Copy link
Member Author

tnozicka commented Oct 2, 2024

/test images

@tnozicka
Copy link
Member Author

tnozicka commented Oct 2, 2024

/retest

@tnozicka
Copy link
Member Author

tnozicka commented Oct 2, 2024

find is missing - scylladb/scylla-operator-images#73

@tnozicka
Copy link
Member Author

tnozicka commented Oct 3, 2024

scylladb/scylla-operator-images#73 has landed
/retest

@tnozicka
Copy link
Member Author

tnozicka commented Oct 3, 2024

/test images

@tnozicka
Copy link
Member Author

tnozicka commented Oct 3, 2024

/retest

@tnozicka
Copy link
Member Author

tnozicka commented Oct 3, 2024

mount is missing - scylladb/scylla-operator-images#75

@tnozicka
Copy link
Member Author

tnozicka commented Oct 4, 2024

scylladb/scylla-operator-images#75 landed
/test images

@tnozicka
Copy link
Member Author

tnozicka commented Oct 4, 2024

/retest

@tnozicka tnozicka changed the title [WIP] Switch runtime image to the new UBI base image Switch runtime image to the new UBI base image Oct 4, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2024
@tnozicka
Copy link
Member Author

tnozicka commented Oct 4, 2024

all green now, ptal

Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 411aff7 into scylladb:master Oct 4, 2024
11 of 12 checks passed
@tnozicka tnozicka deleted the use-ubi branch October 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to ubi-minimal images
2 participants