-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate numerical_distrubutions
parameter
#1234
Conversation
Codecov ReportBase: 95.66% // Head: 95.69% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## V1.0.0.dev #1234 +/- ##
==============================================
+ Coverage 95.66% 95.69% +0.03%
==============================================
Files 47 47
Lines 3618 3627 +9
==============================================
+ Hits 3461 3471 +10
+ Misses 157 156 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b1ffd94
to
3de01d7
Compare
The issue only mentions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some refactoring to reuse the same piece of code and not duplicate it then it should be good to go.
* Add code * Add TypeError tests * Move _validate to utils * Add doscstring to validate_num_dist * Fix lint * Fix docs
* Add code * Add TypeError tests * Move _validate to utils * Add doscstring to validate_num_dist * Fix lint * Fix docs
Resolve #1211.