Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate numerical_distrubutions parameter #1234

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 6, 2023

Resolve #1211.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Base: 95.66% // Head: 95.69% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d75b6ff) compared to base (5f586ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d75b6ff differs from pull request most recent head af148c1. Consider uploading reports for the commit af148c1 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##           V1.0.0.dev    #1234      +/-   ##
==============================================
+ Coverage       95.66%   95.69%   +0.03%     
==============================================
  Files              47       47              
  Lines            3618     3627       +9     
==============================================
+ Hits             3461     3471      +10     
+ Misses            157      156       -1     
Impacted Files Coverage Δ
sdv/single_table/copulagan.py 95.83% <100.00%> (+0.18%) ⬆️
sdv/single_table/copulas.py 95.74% <100.00%> (+0.67%) ⬆️
sdv/single_table/utils.py 85.12% <100.00%> (+1.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fealho
Copy link
Member Author

fealho commented Feb 6, 2023

The issue only mentions GaussianCopulaSynthesizer, but I believe CopulaGANSynthesizer should be updated as well.

@fealho fealho marked this pull request as ready for review February 6, 2023 22:12
@fealho fealho requested a review from a team as a code owner February 6, 2023 22:12
@fealho fealho requested review from frances-h, pvk-developer and amontanez24 and removed request for a team and frances-h February 6, 2023 22:12
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some refactoring to reuse the same piece of code and not duplicate it then it should be good to go.

sdv/single_table/copulas.py Outdated Show resolved Hide resolved
sdv/single_table/copulagan.py Outdated Show resolved Hide resolved
sdv/single_table/copulagan.py Outdated Show resolved Hide resolved
@fealho fealho merged commit 9560adf into V1.0.0.dev Feb 7, 2023
@fealho fealho deleted the issue-1211-numerical-distribution branch February 7, 2023 16:01
amontanez24 pushed a commit that referenced this pull request Feb 17, 2023
* Add code

* Add TypeError tests

* Move _validate to utils

* Add doscstring to validate_num_dist

* Fix lint

* Fix docs
amontanez24 pushed a commit that referenced this pull request Mar 23, 2023
* Add code

* Add TypeError tests

* Move _validate to utils

* Add doscstring to validate_num_dist

* Fix lint

* Fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants