Log columns in numerical_distributions which have been renamed
#1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
changed the base branch from
V1.0.0.dev
to
issue-1211-numerical-distribution
fealho
requested review from
pvk-developer and
amontanez24
and removed request for
a team
amontanez24
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
This looks good! One thing I noticed for both this PR and #1234 is that there are very similar validations being done in both CopulaGANSynthesizer and CopulasSynthesizer. In the future maybe we should consider places where validation is repetitive and think about pulling that out into it's own module or something like that
pvk-developer
approved these changes
Feb 7, 2023
Base automatically changed from
issue-1211-numerical-distribution
to
V1.0.0.dev
February 7, 2023 16:01
fealho
force-pushed
the
issue-1234-log-numerical-distribution
branch
from
cb52e4d to
8338307
Compare
amontanez24
reviewed
Feb 8, 2023
sdv/single_table/copulagan.py
Outdated
Comment on lines
185
to
191
| unseen_columns = self._numerical_distributions.keys() - set(processed_data.columns) | ||
| for column in unseen_columns: | ||
| LOGGER.info( | ||
| f"Requested distribution '{self.numerical_distributions[column]}' " | ||
| f"cannot be applied to column '{column}' because it no longer " | ||
| 'exists after preprocessing.' | ||
| ) |
There was a problem hiding this comment.
I think we can move this validation out to utils and pass the logger
fealho
force-pushed
the
issue-1234-log-numerical-distribution
branch
from
7b9a513 to
7ac9005
Compare
amontanez24
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Add code * Add LOGGER, weird bug * Fix last dict->set * Add bug fix * Fix bugs + add tests * Remove _validates added during rebase * Move logger to utils
amontanez24
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add code * Add LOGGER, weird bug * Fix last dict->set * Add bug fix * Fix bugs + add tests * Remove _validates added during rebase * Move logger to utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1212.