Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context metadata adjusted for the transformed datetime sdtype #2127

Merged
merged 7 commits into from
Jul 17, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #1485
CU-85ztdkk6d

Since this datetime is being read incorrectly to the context model there are were a couple approaches:

  • Do not transform the column before it gets to context synthesizer (unfortunately this causes errors when trying to map the context synthesizer values in the par model)
  • Update transformers in the context model (cannot easily swap the transformers before validation occurs)
  • Change the type of the context metadata to match

Went with last one because the context metadata is a deep copy of the metadata and is not surfaced/used to any other functionality besides fitting the context model.

@lajohn4747 lajohn4747 requested a review from a team as a code owner July 15, 2024 15:16
@sdv-team
Copy link
Contributor

sdv/sequential/par.py Outdated Show resolved Hide resolved
@lajohn4747 lajohn4747 requested a review from frances-h July 16, 2024 18:33
@lajohn4747 lajohn4747 requested a review from amontanez24 July 17, 2024 16:01
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/unit/sequential/test_par.py Outdated Show resolved Hide resolved
@lajohn4747 lajohn4747 merged commit fa01804 into main Jul 17, 2024
39 checks passed
@lajohn4747 lajohn4747 deleted the issue_1485_datetime_context branch July 17, 2024 17:45
@lajohn4747 lajohn4747 self-assigned this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In PARSynthesizer I cannot pass in datetime context (InvalidDataError during fitting)
4 participants