Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional sampling using GaussianCopula inefficient when categories are noised #912

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conditional sampling using GaussianCopula inefficient when categories are noised #912

merged 1 commit into from
Jul 19, 2022

Conversation

amontanez24
Copy link
Contributor

resolves #910

@amontanez24 amontanez24 requested a review from a team as a code owner July 19, 2022 01:29
@amontanez24 amontanez24 requested review from katxiao and a team and removed request for a team July 19, 2022 01:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #912 (8d02933) into master (8b1a87e) will decrease coverage by 0.01%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   68.60%   68.59%   -0.02%     
==========================================
  Files          38       38              
  Lines        2867     2866       -1     
==========================================
- Hits         1967     1966       -1     
  Misses        900      900
Impacted Files Coverage Δ
sdv/tabular/base.py 82.85% <70.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1a87e...8d02933. Read the comment docs.

katxiao
katxiao approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@katxiao katxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

pvk-developer
pvk-developer approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@amontanez24 amontanez24 merged commit ba8e330 into master Jul 19, 2022
@amontanez24 amontanez24 deleted the issue-910-transforming-conditions-inefficient branch July 19, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@katxiao katxiao katxiao approved these changes

@fealho fealho Awaiting requested review from fealho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional sampling using GaussianCopula inefficient when categories are noised
4 participants
@amontanez24 @codecov-commenter @katxiao @pvk-developer