Fix configuration generation #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChristianKaltenecker Do you have an idea what is wrong with the solver here? |
For some reason, this caused other configs to appear multiple times during enumeration.
This caused 2 issues: - either first config was skipped or getCurrentConfig would always point to the next configuration - getAllValidConfigurations or getNumberValidConfigurations produce incorrect results if called after any call to getNextConfiguration() The last point is an issue with the Solver API and this is a quick-fix for the Z3Solver implementation that returns an error in that case.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #126 +/- ##
============================================
- Coverage 89.67% 89.63% -0.05%
============================================
Files 73 73
Lines 6991 6982 -9
============================================
- Hits 6269 6258 -11
- Misses 722 724 +2 ☔ View full report in Codecov by Sentry. |
vulder
requested changes
Oct 23, 2023
This implementation is quite hacky and requires a redesign of the Solver API to be fixed properly.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This issue is more complicated than assumed. The current state of this PR should be considered a quick-fix. Do not merge until it is properly resolved. |
That means that model enumeration is no longer part of the solver interface, but should be done using the ConfigurationFactory and ConfigurationIterator.
|
This is now ready for review. |
vulder
reviewed
Nov 9, 2023
vulder
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittest for https://github.com/se-sic/VaRA/issues/1043