Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration generation #126

Merged
merged 11 commits into from
Nov 17, 2023
Merged

Fix configuration generation #126

merged 11 commits into from
Nov 17, 2023

Commits on Oct 6, 2023

  1. Add GetAllConfigurations2 unittest to detect bug

    @danjujan
    danjujan committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    0f33534 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Do not exclude the first config. 

    For some reason, this caused other configs to appear multiple times during enumeration.
    @boehmseb
    boehmseb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    eb11193 View commit details
    Browse the repository at this point in the history

  2. Avoid unnecessary solver calls.

    @boehmseb
    boehmseb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    67ac14e View commit details
    Browse the repository at this point in the history

  3. Use for-each loop to iterate maps.

    @boehmseb
    boehmseb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b50117d View commit details
    Browse the repository at this point in the history

  4. Temporary fix for side effects of getNextConfiguration() 

    This caused 2 issues:
- either first config was skipped or getCurrentConfig would always point to the next configuration
- getAllValidConfigurations or getNumberValidConfigurations produce incorrect results if called after any call to getNextConfiguration()
The last point is an issue with the Solver API and this is a quick-fix for the Z3Solver implementation that returns an error in that case.
    @boehmseb
    boehmseb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    28bddd7 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Apply suggested changes.

    @boehmseb
    boehmseb committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1e5aa2b View commit details
    Browse the repository at this point in the history

  2. Quick-fix to make configuration enumeration work. 

    This implementation is quite hacky and requires a redesign of the Solver API to be fixed properly.
    @boehmseb
    boehmseb committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    67463ab View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Change solver interface to better work with internal solver states. 

    That means that model enumeration is no longer part of the solver interface, but should be done using the ConfigurationFactory and ConfigurationIterator.
    @boehmseb
    boehmseb committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8e4b1dc View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Run pre-commit

    @boehmseb
    boehmseb committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5197c1c View commit details
    Browse the repository at this point in the history

  2. Fix clang-tidy warnings

    @boehmseb
    boehmseb committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3c50e00 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Merge branch 'vara-dev' into fix-configuration-generation

    @vulder
    vulder committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    709341e View commit details
    Browse the repository at this point in the history