Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the dependency on PEAR #1101

Closed
sebastianbergmann opened this issue Jan 15, 2014 · 5 comments
Closed

Get rid of the dependency on PEAR #1101

sebastianbergmann opened this issue Jan 15, 2014 · 5 comments
Labels
type/enhancement A new idea that should be implemented type/refactoring A refactoring that should be applied to make the code easier to understand and maintain

Comments

@sebastianbergmann
Copy link
Owner

Refactor PHPUnit_Extensions_PhptTestCase to not require PEAR_RunTest. This requires the implementation of a custom PHPT test runner that leverages assertStringMatchesFormat().
sebastianbergmann added a commit that referenced this issue Jan 15, 2014
@sebastianbergmann
Initial work on #1101
46ab6ee
sebastianbergmann added a commit that referenced this issue Jan 18, 2014
@sebastianbergmann
Initial work on #1101
db5adbb
@sebastianbergmann
Copy link
Owner Author

Implemented in 0955930

@whatthejeff
Copy link
Contributor

Awesome!

@sebastianbergmann
Copy link
Owner Author

It works for our own PHPT tests. Only ---TEST---, ---FILE---, ---EXPECT---, and ---EXPECTF--- are supported. For me (us), this is sufficient. I am not against adding support for other PHPT sections but I won't be the one implementing them.

@sebastianbergmann
Copy link
Owner Author

It fails on Travis CI. I cannot reproduce it locally. Weird.

@Ocramius Ocramius mentioned this issue Jan 28, 2014
Closed
@whatthejeff
Copy link
Contributor

I wonder if this has something to do with the INI overrides from PEAR_RunTest. Seems if we don't force certain configurations that the output can vary depending on the runtime.

@henriquemoody henriquemoody mentioned this issue Dec 30, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A new idea that should be implemented type/refactoring A refactoring that should be applied to make the code easier to understand and maintain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @whatthejeff