PHPT improvements #1552
Closed
PHPT improvements #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianbergmann, any thought about this? |
|
@henriquemoody: why was this abandoned? I have |
|
After almost 5 months with no feedback I decided to close this pull request, I thought it was not important. |
|
:( |
|
Same for #1550. |
|
Which was really strange, BTW, because #1719 was merged one month ago. Edit: It was merged after I close these pull requests. |
|
I am sorry that I am bad / slow at giving feedback. |
|
I rebased and created a new pull request #1824. |
|
BTW, no problem at all, @sebastianbergmann. I know you're a very busy person who runs a lot of projects, and perhaps this pull request was not a priority in your list. I will let #1824 opened until you give some feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit_Util_PHPinstance onPHPUnit_Extensions_PhptTestCaseCLEANsection for PHPT testsEXPECTREGEXsection for PHPT testsAccording to Sebastian Bergmann I don't think this would be a problem.