Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add PHP 8 to build matrix #3979

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

localheinz
Copy link
Collaborator

@localheinz localheinz commented Dec 9, 2019

This PR

  • adds PHP 8 to the build matrix

💁‍♂ For reference, see shivammathur/setup-php#104.

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #3979 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3979   +/-   ##
=========================================
  Coverage     85.46%   85.46%           
  Complexity     3848     3848           
=========================================
  Files           156      156           
  Lines          9719     9719           
=========================================
  Hits           8306     8306           
  Misses         1413     1413

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0575997...80f4564. Read the comment docs.

@shivammathur
Copy link
Contributor

@sebastianbergmann @localheinz
Please quote these versions as GitHub Actions truncates zeros after decimal in inputs.

php-version:
  - '7.3'
  - '7.4'
  - '8.0'

@localheinz
Copy link
Collaborator Author

Thank you, @shivammathur!

@shivammathur
Copy link
Contributor

@localheinz
Please note that Xdebug currently does not support this version.

@localheinz
Copy link
Collaborator Author

Thank you for clarifying, @shivammathur!

@sebastianbergmann sebastianbergmann merged commit c86ffb9 into sebastianbergmann:master Dec 9, 2019
@localheinz localheinz deleted the feature/php8 branch December 9, 2019 09:25
@localheinz
Copy link
Collaborator Author

Thank you, @sebastianbergmann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants