Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation of PHP 8 #104

Closed
localheinz opened this issue Dec 6, 2019 · 6 comments · Fixed by #105
Closed

Allow installation of PHP 8 #104

localheinz opened this issue Dec 6, 2019 · 6 comments · Fixed by #105
Assignees
Labels
enhancement New feature or request

Comments

@localheinz
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It would be nice to be able to install PHP 8 (https://github.com/php/php-src/tree/master).

Describe the solution you'd like

Add version alias master or similar, which allowed installing PHP 8 (https://github.com/php/php-src/tree/master).

Describe alternatives you've considered

n/a

Additional context

n/a

@shivammathur
Copy link
Owner

shivammathur commented Dec 6, 2019

Working on this currently.
https://github.com/shivammathur/setup-php/projects/1#card-29611356

@shivammathur shivammathur self-assigned this Dec 6, 2019
@shivammathur shivammathur added the enhancement New feature or request label Dec 6, 2019
shivammathur added a commit that referenced this issue Dec 9, 2019
shivammathur added a commit that referenced this issue Dec 9, 2019
@shivammathur shivammathur removed the WIP label Dec 9, 2019
@shivammathur shivammathur mentioned this issue Dec 9, 2019
@shivammathur
Copy link
Owner

shivammathur commented Dec 9, 2019

@localheinz

uses: shivammathur/setup-php@v1
with:
  php-version: '8.0'

This will now setup a nightly build PHP 8.0.0-dev from the master branch of php/php-src on ubuntu and macOS.
The build has JIT compiler enabled with the following configuration. You can use ini-values input to change these values. Refer to this RFC for details - https://wiki.php.net/rfc/jit

opcache.jit_buffer_size = 256M
opcache.jit = 1235
pcre.jit = 1

@localheinz
Copy link
Contributor Author

@shivammathur

Awesome, thank you!

@sebastianbergmann
Copy link

@shivammathur Thank you! We (and by that I mean @localheinz) we use this ASAP for PHPUnit's CI pipeline(s).

@localheinz
Copy link
Contributor Author

@shivammathur
Copy link
Owner

shivammathur commented Dec 9, 2019

@localheinz
Please quote these versions as GitHub Actions truncates zeros after decimal in inputs.

php-version:
  - '7.3'
  - '7.4'
  - '8.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants