Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the all-dependencies group with 3 updates #716

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 18, 2024

Bumps the all-dependencies group with 3 updates: Scriban, Microsoft.Extensions.FileProviders.Abstractions and System.Text.Json.

Updates Scriban from 5.11.0 to 5.12.0

Release notes

Sourced from Scriban's releases.

5.12.0

Changes

🐛 Bug Fixes

Full Changelog: 5.11.0...5.12.0

Published with dotnet-releaser

Commits

Updates Microsoft.Extensions.FileProviders.Abstractions from 8.0.0 to 9.0.0

Release notes

Sourced from Microsoft.Extensions.FileProviders.Abstractions's releases.

.NET 9.0.0

Release

What's Changed

... (truncated)

Commits

Updates System.Text.Json from 8.0.5 to 9.0.0

Release notes

Sourced from System.Text.Json's releases.

.NET 9.0.0

Release

What's Changed

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the all-dependencies group with 3 updates: [Scriban](https://github.com/scriban/scriban), [Microsoft.Extensions.FileProviders.Abstractions](https://github.com/dotnet/runtime) and [System.Text.Json](https://github.com/dotnet/runtime).


Updates `Scriban` from 5.11.0 to 5.12.0
- [Release notes](https://github.com/scriban/scriban/releases)
- [Changelog](https://github.com/scriban/scriban/blob/master/changelog.md)
- [Commits](scriban/scriban@5.11.0...5.12.0)

Updates `Microsoft.Extensions.FileProviders.Abstractions` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.0...v9.0.0)

Updates `System.Text.Json` from 8.0.5 to 9.0.0
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v8.0.5...v9.0.0)

---
updated-dependencies:
- dependency-name: Scriban
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: Microsoft.Extensions.FileProviders.Abstractions
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-dependencies
- dependency-name: System.Text.Json
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 18, 2024
@hishamco hishamco merged commit bd0c42f into main Nov 18, 2024
1 check passed
@hishamco hishamco deleted the dependabot/nuget/all-dependencies-014e31d830 branch November 18, 2024 23:24
@sebastienros
Copy link
Owner

I didn't merge on purpose, I should have added flag.
I need to investigate requiring 9.0.0. It might be ok, it might not.

@hishamco
Copy link
Collaborator

Sorry, let me check after the update and run benchmarks, but I presume such PRs trigger the build, right?

@sebastienros
Copy link
Owner

It's about the dependencies it pulls in. And that other libraries will now have to also use 9.0 or will see a downgrade message. What if you target net8.0 (OC?) and reference these, what is pulled in, LTS, ...

@hishamco
Copy link
Collaborator

What about about upgrading to .NET 9.0, I planned to submit a PR but I am not sure when OC will bump the .NET version?

Regarding this PR I will check the dependency and let you know if there's dependency on .NET 9

@sebastienros
Copy link
Owner

Regarding this PR I will check the dependency and let you know if there's dependency on .NET 9

What does it even mean?

What about about upgrading to .NET 9.0

Fluid is a library. The final app decides what to target. Targeting 9 in apps and libraries means totally different things.

@@ -4,16 +4,16 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.Extensions.FileProviders.Abstractions" Version="8.0.0" />
<PackageVersion Include="Microsoft.Extensions.FileProviders.Abstractions" Version="9.0.0" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this either, 8.0.0 should be quite fine and doesn't alarm bells when you are still running LTS NET 8 stack, libs probably work as expected, but still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants