Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace uuid dependency with native crypto method #631

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

backflip
Copy link
Contributor

@backflip backflip commented Jan 3, 2025

About this Pull Request

  • What kind of change does this PR introduce?
    • Replace external uuid-random dependency with native crypto.randomUUID. No need to use external code for something the platform provides.
  • What is the current behavior?
    • Usage of external dependency.
  • What is the new behavior?
    • Usage of native functionality.
  • Does this PR introduce a breaking change?
    • As crypto.randomUUID has been introduced with Node.js 16.7.0 and the engine config in this project's package.json states "node": "18 || 20 || >=22.0.0", this should not break anything.
  • Other information:

Pull Request Checklist

  • My code follows the code style of this project
    • Run npm run lint to double check
  • My change requires a change to the documentation
    • I have updated the documentation accordingly
  • I have added tests to cover my changes
    • Run npm run test to run the unit tests and npm run coverage to generate a coverage report
  • All new and existing tests passed
  • My commit messages follow the commit guidelines

@sebbo2002 sebbo2002 merged commit 0cbd887 into sebbo2002:develop Jan 4, 2025
@sebbo2002
Copy link
Owner

I've still counter-checked this as I didn't have the removal of random-uuid on my mind until the deprecation of node.js v18. But you are absolutely right, it came earlier than I thought. Thank you very much.

@sebbo2002
Copy link
Owner

🎉 This PR is included in version 8.1.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebbo2002
Copy link
Owner

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants