fix: Use WebCrypto instead of node crypto module #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this Pull Request
Fixes #632
Removing
uuid-randomin #631 had the unintended side effect of breaking compatibility with non-node platforms (importing from the 'crypto' module is node specific.)This change swaps out node's randomUUID implementation with webcrypto's
crypto.randomUUIDinstead. This is supported on all current node versions, cloudflare workers etc.It should also work in Web Workers, unless on an ancient browser version.
Pull Request Checklist