Function return struct #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 66.15% 66.38% +0.22%
==========================================
Files 93 97 +4
Lines 13150 13245 +95
Branches 2035 1946 -89
==========================================
+ Hits 8700 8793 +93
- Misses 3480 3485 +5
+ Partials 970 967 -3
Continue to review full report at Codecov.
|
hydai
requested changes
Jun 10, 2021
jacky860226
force-pushed
the
function_return_struct
branch
from
aa330a8 to
36c7426
Compare
ibmibmibm
requested changes
Jun 15, 2021
| std::vector<TypePtr> ParamTypes; | ||
| std::vector<TypePtr> ReturnTypes; | ||
| std::vector<std::reference_wrapper<const TypePtr>> ParamTypes; | ||
| std::vector<std::reference_wrapper<const TypePtr>> ReturnTypes; |
There was a problem hiding this comment.
resolve UndefineType會更換到TypePtr的本體所以用reference包起來
Type*是從TypePtr.get()來的，.get()拿不到reference
jacky860226
force-pushed
the
function_return_struct
branch
from
d1659e9 to
db349e7
Compare
jacky860226
force-pushed
the
function_return_struct
branch
from
db349e7 to
579b5c3
Compare
hydai
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the bug of function return a Struct.
prepare for function return a Tuple #85.