Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS support for Trillian server (#2164) #301

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Add TLS support for Trillian server (#2164) #301

merged 4 commits into from
Aug 21, 2024

Conversation

fghanmi
Copy link

@fghanmi fghanmi commented Aug 3, 2024

Summary

This pull request introduces support for enabling TLS in communications with the Trillian server. By adding a new command-line flag --trillian_log_server.tls_ca_cert and implementing the necessary logic to handle TLS certificates, this update enhances the security of Rekor.

Release Note

  • Feature: Added support for TLS in communication with the Trillian server.
  • New Flag:
    • --trillian_log_server.tls_ca_cert to specify the CA certificate file path for secure connections.

Resolves Issue: sigstore#2163

fghanmi and others added 3 commits August 14, 2024 18:19
* Add TLS support for Trillian server

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>

* update tls_ca_cert key name

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>

---------

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fghanmi, JasonPowr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr merged commit 4c5035c into main Aug 21, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants