Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly metrics #81

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Nightly metrics #81

merged 4 commits into from
Nov 15, 2023

Conversation

tommyd450
Copy link
Contributor

WIP for the nightly metrics scraping, if im missing anything let me know.

@tommyd450
Copy link
Contributor Author

Currently has some place holders in it as I did some of this earlier today let me know what needs changing and ill get to it.

Copy link
Contributor

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm but 1 comment

@Gregory-Pereira Gregory-Pereira force-pushed the nightlyMetrics branch 2 times, most recently from 248a692 to 90c72e7 Compare November 10, 2023 05:10
@Gregory-Pereira
Copy link
Contributor

Gregory-Pereira commented Nov 10, 2023

Current status, chart installs and on completion it does have the ability to trigger the job, but the job is failing hitting backoff-limit, will debug it tomorrow.

However we have another issue. If we are gonna ship the cronjob and job with the charts, its trying to send it to the sigstore-monitoring namespace but that does not exist because its not included in the base charts, but we have it as the seperate grafana install script. Therefore i suggest we ship the sigstore-monitoring namespace with the helm charts, but keep the script to install everything else @sallyom

@Gregory-Pereira Gregory-Pereira force-pushed the nightlyMetrics branch 2 times, most recently from 8386cc7 to 19c96ab Compare November 10, 2023 05:28
@Gregory-Pereira
Copy link
Contributor

Ready for review

Updated templates based on the segment-backup-job repo
@Gregory-Pereira Gregory-Pereira force-pushed the nightlyMetrics branch 2 times, most recently from d007ffc to 8388261 Compare November 15, 2023 18:43
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance merged commit 4c07b4d into main Nov 15, 2023
1 of 3 checks passed
bouskaJ added a commit that referenced this pull request Nov 16, 2023
* Update resources to work with image SHAs (#85)

* Nightly metrics (#81)

* Added nightly cronjob template
Updated templates based on the segment-backup-job repo

* adding job for post-install and moving job to cronjob for nightly metrics

* chore: update segment-backup-job sha

Signed-off-by: Lance Ball <lball@redhat.com>

* adding job for post-install and moving job to cronjob for nightly metrics

---------

Signed-off-by: Lance Ball <lball@redhat.com>
Co-authored-by: greg pereira <grpereir@redhat.com>
Co-authored-by: Lance Ball <lball@redhat.com>

---------

Signed-off-by: Lance Ball <lball@redhat.com>
Co-authored-by: Jan Bouska <jbouska@redhat.com>
Co-authored-by: Tommy Dalton <59835082+tommyd450@users.noreply.github.com>
Co-authored-by: greg pereira <grpereir@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants