enable using personalized pull-secret #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
sallyom
reviewed
Nov 9, 2023
|
Just to clarify, Sally, By non-default pull-secret do you mean the TAS specific one that people can download from the console dot? If so that is used for metrics in the write home job to we can track usage and installations. +1 on all the other eventual requirements, I think that stuff is important, but I think it might be a good idea to implement those when we move to the operator. |
|
Moving this to nightlyMetrics pr (#81) because it fits better there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @lance
/cc @tommyd450