First cut of ESLint upgrade #1047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 92e5410 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AaronMoat
commented
Sep 8, 2024
| }; | ||
| const baseConfig = [ | ||
| { | ||
| ignores: [ |
There was a problem hiding this comment.
Worth considering if you migrate this on behalf of users (any custom .eslintignore they have) in some form, or just say "use dangerouslySetESLintConfig" or similar
AaronMoat
commented
Sep 8, 2024
| path.join(skuPackagePath, 'config/eslint/importOrderConfig.js'), | ||
| ]); | ||
| }); | ||
| it.todo('should generate a eslint config'); |
There was a problem hiding this comment.
Was too lazy to fix this test :) and one below
|
@AaronMoat I was working off this branch 😅. Feel free to keep the PR/branch around. |
|
Sorry @askoufis! |
|
Closing the PR but keeping the branch. I'll probably be force-pushing over it soon ™️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't currently intend to fully perform this upgrade on behalf of the sku maintainers, but I wanted to do a first cut of the upgrade to make sure seek-oss/eslint-config-seek#145 wasn't horribly wrong. It seems ok?