Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1359 add sample ids to dynamic and exported tables #1436

Conversation

kdp-cloud
Copy link
Collaborator

This pull request contains the following features:

  • Addition of Fairdom ID and uuid to the dynamic table
  • Export the content of the dynamic table to an excel sheet

Kevin De Pelseneer added 20 commits March 31, 2023 14:05
…_Add_Sample_IDs_to_dynamic_and_exported_tables
…_Add_Sample_IDs_to_dynamic_and_exported_tables
… column.\n- Replaced the download csv file with a download xlsx button.
- Added instance variables
- Made data validation more dynamic
…adsheet:

- Add instance variables
- Caching between requests
- Added error handling
…_Add_Sample_IDs_to_dynamic_and_exported_tables
@kdp-cloud kdp-cloud changed the title Issue 1359 add sample i ds to dynamic and exported tables Issue 1359 add sample ids to dynamic and exported tables May 4, 2023
@kdp-cloud kdp-cloud linked an issue May 4, 2023 that may be closed by this pull request
3 tasks
@kdp-cloud kdp-cloud marked this pull request as ready for review May 4, 2023 08:32
@kdp-cloud kdp-cloud marked this pull request as draft May 4, 2023 11:32
@kdp-cloud kdp-cloud marked this pull request as ready for review May 5, 2023 07:10
app/controllers/single_pages_controller.rb Outdated Show resolved Hide resolved
app/controllers/single_pages_controller.rb Outdated Show resolved Hide resolved
Kevin De Pelseneer added 5 commits May 10, 2023 16:25
…e selected now. See [issue seek4science#1422](seek4science#1422)

- Excel sheet now shows whether a field is required. Headers have an '*'
  and the the data validation prompt also tells whether the field is
mandatory or optional.
@kdp-cloud kdp-cloud marked this pull request as draft May 17, 2023 13:10
@kdp-cloud kdp-cloud linked an issue May 30, 2023 that may be closed by this pull request
Kevin De Pelseneer and others added 11 commits June 12, 2023 10:27
…dd_Sample_IDs_to_dynamic_and_exported_tables
- Make exportToExcel async
- renamed sample_data
- Making export functionality instance-agnostic
- Made source sample table test instance-agnostic

- New test for exporting samples from a sample collection table or assay sample table

- format document
Kevin De Pelseneer added 2 commits June 22, 2023 15:58
…s' of github.com:ELIXIR-Belgium/seek into issue_1359_Add_Sample_IDs_to_dynamic_and_exported_tables
@kdp-cloud kdp-cloud marked this pull request as ready for review June 23, 2023 06:49
@kdp-cloud kdp-cloud requested a review from stuzart June 23, 2023 06:49
Copy link
Member

@stuzart stuzart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really minor comment, but otherwise can merge

Gemfile Outdated
gem 'caxlsx', '>= 3.0' # Write content to an xlsx file
gem 'caxlsx_rails', '~> 0.6.2'

# to avoid warnings after rails 6.1.7.2 update - see https://github.com/ruby/net-imap/issues/16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is no longer needed, not sure why it has reappeared but was fixed with ruby 3.1, but net-ftp is still needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the comment.

@kdp-cloud kdp-cloud merged commit f8627f4 into seek4science:main Jun 28, 2023
11 checks passed
@kdp-cloud kdp-cloud deleted the issue_1359_Add_Sample_IDs_to_dynamic_and_exported_tables branch November 14, 2023 14:49
@kdp-cloud kdp-cloud added this to the v1.14.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Improvement of export samples via dynamic table Add Sample IDs to the dynamic table and exported table
3 participants