-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1359 add sample ids to dynamic and exported tables #1436
Issue 1359 add sample ids to dynamic and exported tables #1436
Conversation
…_Add_Sample_IDs_to_dynamic_and_exported_tables
…_Add_Sample_IDs_to_dynamic_and_exported_tables
… column.\n- Replaced the download csv file with a download xlsx button.
- Added instance variables - Made data validation more dynamic
…adsheet: - Add instance variables - Caching between requests - Added error handling
…_Add_Sample_IDs_to_dynamic_and_exported_tables
…e selected now. See [issue seek4science#1422](seek4science#1422) - Excel sheet now shows whether a field is required. Headers have an '*' and the the data validation prompt also tells whether the field is mandatory or optional.
…dd_Sample_IDs_to_dynamic_and_exported_tables
- Make exportToExcel async
- renamed sample_data - Making export functionality instance-agnostic
- Made source sample table test instance-agnostic - New test for exporting samples from a sample collection table or assay sample table - format document
…s' of github.com:ELIXIR-Belgium/seek into issue_1359_Add_Sample_IDs_to_dynamic_and_exported_tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really minor comment, but otherwise can merge
Gemfile
Outdated
gem 'caxlsx', '>= 3.0' # Write content to an xlsx file | ||
gem 'caxlsx_rails', '~> 0.6.2' | ||
|
||
# to avoid warnings after rails 6.1.7.2 update - see https://github.com/ruby/net-imap/issues/16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is no longer needed, not sure why it has reappeared but was fixed with ruby 3.1, but net-ftp is still needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the comment.
This pull request contains the following features: