Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid constantize #1503

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Avoid constantize #1503

merged 4 commits into from
Jul 5, 2023

Conversation

fbacall
Copy link
Contributor

@fbacall fbacall commented Jul 5, 2023

Provides a safer way of retrieving the class of a SEEK resource.

Fixes CodeQL warnings.

`controller_model` for current controller
`safe_class_lookup(...)` to safely get a SEEK resource class from a string
Change class variable to instance variable (it's already on the Module itself)
@stuzart stuzart merged commit 30e1618 into main Jul 5, 2023
25 checks passed
@fbacall fbacall deleted the avoid-constantize branch July 14, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants