Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid constantize #1503

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Avoid constantize #1503

merged 4 commits into from
Jul 5, 2023

Commits on Jun 16, 2023

  1. Consolidate ways of retrieving class from string 

    `controller_model` for current controller
`safe_class_lookup(...)` to safely get a SEEK resource class from a string
    @fbacall
    fbacall committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a5f93f9 View commit details
    Browse the repository at this point in the history

  2. Test fixes

    @fbacall
    fbacall committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ebabef8 View commit details
    Browse the repository at this point in the history

  3. Replace constantize in publishing code

    @fbacall
    fbacall committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a1a021f View commit details
    Browse the repository at this point in the history

  4. Faster class lookup 

    Change class variable to instance variable (it's already on the Module itself)
    @fbacall
    fbacall committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    f78080b View commit details
    Browse the repository at this point in the history