Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to the observation unit UI #1975

Merged
merged 11 commits into from
Aug 23, 2024
Merged

Additions to the observation unit UI #1975

merged 11 commits into from
Aug 23, 2024

Conversation

stuzart
Copy link
Member

@stuzart stuzart commented Aug 21, 2024

Consolidated earlier changes with those done by PhenomUK.
Added ability to associate a data file or sample

@stuzart stuzart added this to the 1.16.0 milestone Aug 21, 2024
Copy link
Collaborator

@AndrewWood94 AndrewWood94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed on new Obs Unit file, otherwise all good

Copy link
Collaborator

@AndrewWood94 AndrewWood94 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text for no Investigation/Study available is still referencing Assay not Obs Unit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot

@stuzart stuzart merged commit 83ffcc2 into main Aug 23, 2024
25 checks passed
@stuzart stuzart deleted the more-obs-unit-ui-1961 branch August 23, 2024 11:35
@stuzart
Copy link
Member Author

stuzart commented Aug 23, 2024

Minor changes needed on new Obs Unit file, otherwise all good

Thanks. I fixed the error and based on this comment gone straight ahead and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants