Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Linear Units and added FromURN #32

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

WillGunther
Copy link
Contributor

Description

  • I was having some some segfaults while testing my WMTS stuff and calling LinearUnits. Based on the docs I think that the pointer we are giving the function is being overwritten by a pointer to something in C land, and then we are trying to free it. This shouldn't be a memory leak as long as the SR is destroyed.
  • Added a from URN convenience function. I spent some time looking for it because it is listed in gdal docs, but it turns out there is no binding for it because SetFromUserInput does the same thing

Testing

unit testing

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.77%. Comparing base (9019316) to head (3d18c09).

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #32      +/-   ##
========================================
+ Coverage   5.57%   5.77%   +0.20%     
========================================
  Files          7      12       +5     
  Lines       3158    3324     +166     
========================================
+ Hits         176     192      +16     
- Misses      2975    3125     +150     
  Partials       7       7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillGunther WillGunther merged commit a0923e8 into main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants