Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Angular Units #33

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fixed issue with Angular Units #33

merged 2 commits into from
Apr 15, 2024

Conversation

WillGunther
Copy link
Contributor

Description

Testing

unit testing

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.04%. Comparing base (a0923e8) to head (19b12fa).

❗ Current head 19b12fa differs from pull request most recent head 7ff970a. Consider uploading reports for the commit 7ff970a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #33      +/-   ##
========================================
+ Coverage   5.77%   6.04%   +0.27%     
========================================
  Files         12      12              
  Lines       3324    3323       -1     
========================================
+ Hits         192     201       +9     
+ Misses      3125    3115      -10     
  Partials       7       7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

osr_test.go Outdated
assert.NoError(t, err)

units, value := sr.AngularUnits()
assert.NoError(t, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mega nit: This error is already checked above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Those were copied from above too. Must be some trained behavior to check errors after calling any go function.

@WillGunther WillGunther merged commit 1d14a1d into main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants