Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Add nanoid like sufix to preferenceDialogForm #269

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

edsonjab
Copy link
Contributor

Fix issue #267

@joelpierre
Copy link

Nice one

@nd4p90x nd4p90x linked an issue Sep 14, 2022 that may be closed by this pull request
@nd4p90x nd4p90x added the enhancement New feature or request label Sep 14, 2022
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joelpierre
Copy link

can we merge this? It genuine invalid markup so can be quite serious.

@chrisradek chrisradek merged commit 8a0e3a5 into segmentio:master Oct 17, 2022
@edsonjab edsonjab deleted the fix_preferenceDialogForm branch April 1, 2023 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid markup for "preferenceDialogForm"
4 participants