Seqno config disable #354
Merged
Seqno config disable #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
approved these changes
Nov 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 55.41% 55.41% -0.01%
==========================================
Files 620 620
Lines 51690 51694 +4
==========================================
+ Hits 28644 28646 +2
- Misses 20962 20964 +2
Partials 2084 2084
|
philipsu522
added a commit
that referenced
this pull request
Nov 24, 2023
This reverts commit 5f04ca7.
philipsu522
added a commit
that referenced
this pull request
Nov 27, 2023
philipsu522
added a commit
that referenced
this pull request
Nov 28, 2023
philipsu522
added a commit
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add an auth param to allow for disabling seqno checks. The purpose of this is to allow reusing txs which is helpful in testing.
Testing performed to validate your change
Tested on a chain. Also add unti tests