Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Seqno config disable (#354)" #364

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Revert "Seqno config disable (#354)" #364

merged 1 commit into from
Nov 27, 2023

Conversation

philipsu522
Copy link
Contributor

This reverts commit 5f04ca7. We will not go with this approach as it is hacky (even for testing)

Describe your changes and provide context

Testing performed to validate your change

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #364 (3b5175a) into main (5f04ca7) will increase coverage by 0.00%.
The diff coverage is 44.44%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   55.41%   55.41%           
=======================================
  Files         620      620           
  Lines       51694    51690    -4     
=======================================
- Hits        28646    28644    -2     
+ Misses      20964    20962    -2     
  Partials     2084     2084           
Files Coverage Δ
x/auth/ante/sigverify.go 63.35% <100.00%> (-0.23%) ⬇️
x/auth/types/params.go 76.04% <ø> (ø)
x/auth/ante/batch_sigverify.go 0.00% <0.00%> (ø)

@philipsu522 philipsu522 merged commit 1c5a372 into main Nov 27, 2023
14 of 15 checks passed
@philipsu522 philipsu522 deleted the rev-seqno branch November 27, 2023 22:21
philipsu522 added a commit that referenced this pull request Nov 28, 2023
philipsu522 added a commit that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants