Develop #32
Merged
Develop #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better clarity, since this option is about writing output to files, not printing to the console, like eg. `print_progress`. Also changed corresponding variables in the code. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Also changed the default of `print_progress` to false, since it generates a lot of clutter in the console output. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Created `agent_writer.hpp` to provide a more streamlined interface to agent parsing and output. Moved the `to_string` function out of agent Also changed the agent type of the DeGroot model, so that it contains the opinion as `agent.data.opinion`. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
More fitting name, since it also deals with reading in the agents. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Did not compile on the CI. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
The initial convergence check would always return true, since max_opinion was initialized to 0...
Removed the corresponding functions in `agent_generation` and `io`. It makes more sense to localize the agent_io in a single header. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
We created a new folder called `agents`, analogous to the `models` directory. This way, agent types can be reused by different models. Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
We renamed util/io.hpp to network_io.hpp, for consistency with agent_io.hpp. We also removed the IO namespace. Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
This is probably generates false warnings, so we disabled it. Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
Now a lambda function helps set defaults from options.settings, if the user has not entered values. Now all the defaults are not hard-coded. Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
Minor bug. Somehow clang didn't catch it. Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
Io refactor
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Used these attributes to get rid of warnings and to improve code usability. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Fixing typos is very importnt. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
This file is no longer needed. Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO refactor and some minor changes.