Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #32

Merged
merged 20 commits into from
Mar 19, 2024
Merged

Develop #32

merged 20 commits into from
Mar 19, 2024

Commits on Mar 18, 2024

  1. Conf: Renamed print_initial to output_initial

    Better clarity, since this option is about writing output to files, not
    printing to the console, like eg. `print_progress`.
    Also changed corresponding variables in the code.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2d7c7bd View commit details
    Browse the repository at this point in the history
  2. print_options: Now prints all the current settings

    Also changed the default of `print_progress` to false, since it
    generates a lot of clutter in the console output.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ee6e0f4 View commit details
    Browse the repository at this point in the history
  3. IO: Start to refactor agent to/from_string

    Created `agent_writer.hpp` to provide a more streamlined interface
    to agent parsing and output. Moved the `to_string` function out of agent
    Also changed the agent type of the DeGroot model, so that it contains
    the opinion as `agent.data.opinion`.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6daca16 View commit details
    Browse the repository at this point in the history
  4. IO: Also moved agent_from_string to agent_writer

    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    98ed5e1 View commit details
    Browse the repository at this point in the history
  5. IO: Opinion files now contain column names

    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2e1f390 View commit details
    Browse the repository at this point in the history
  6. agent_writer: Renamed to agent_io

    More fitting name, since it also deals with reading in the agents.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    8ff79cd View commit details
    Browse the repository at this point in the history
  7. agent_io: remove static asserts

    Did not compile on the CI.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b289d66 View commit details
    Browse the repository at this point in the history
  8. DeGroot: Fixed bug with convergence check

    The initial convergence check would always return true, since
    max_opinion was initialized to 0...
    MSallermann committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    eae15a3 View commit details
    Browse the repository at this point in the history
  9. agent_io: agents_to_file and agents_from_file

    Removed the corresponding functions in `agent_generation` and `io`.
    It makes more sense to localize the agent_io in a single header.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4303d50 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Agents: Agent data and types in one place

    We created a new folder called `agents`, analogous to the `models`
    directory. This way, agent types can be reused by different models.
    
    Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
    amritagos and MSallermann committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    fe2ddaa View commit details
    Browse the repository at this point in the history
  2. IO: Renamed util/io.hpp to network_io.hpp

    We renamed util/io.hpp to network_io.hpp, for consistency with
    agent_io.hpp. We also removed the IO namespace.
    
    Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
    amritagos and MSallermann committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7168438 View commit details
    Browse the repository at this point in the history
  3. Test_activity: Changed some weird formatting

    Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
    amritagos and MSallermann committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    a93af3c View commit details
    Browse the repository at this point in the history
  4. meson.build: Removed -W-array-bounds warning

    This is probably generates false warnings, so we disabled it.
    
    Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
    amritagos and MSallermann committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8ca2a1c View commit details
    Browse the repository at this point in the history
  5. ConfigParser: Sets defaults from options.settings

    Now a lambda function helps set defaults from options.settings, if the
    user has not entered values. Now all the defaults are not hard-coded.
    
    Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
    amritagos and MSallermann committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ce3f95f View commit details
    Browse the repository at this point in the history
  6. ConfigParser: Fixed bug for Apple Clang

    Minor bug. Somehow clang didn't catch it.
    
    Co-authored-by: Moritz Sallermann <moritzsallermann@gmail.com>
    amritagos and MSallermann committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8c8660a View commit details
    Browse the repository at this point in the history
  7. Merge pull request #31 from seldon-code/io_refactor

    Io refactor
    amritagos authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9ec3868 View commit details
    Browse the repository at this point in the history
  8. Formatting: Minor changes in various files

    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0638cdb View commit details
    Browse the repository at this point in the history
  9. agent_io: [[maybe_unused]] and [[nodiscard]]

    Used these attributes to get rid of warnings and to improve code
    usability.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b214136 View commit details
    Browse the repository at this point in the history
  10. main: "netwok" -> "network"

    Fixing typos is very importnt.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1a3d574 View commit details
    Browse the repository at this point in the history
  11. model.cpp: removed

    This file is no longer needed.
    
    Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
    MSallermann and amritagos committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9f06227 View commit details
    Browse the repository at this point in the history