Skip to content

Unset IDs on resources read errors #53

Merged
merged 3 commits into from
Nov 13, 2018

Conversation

ozerovandrei
Copy link
Contributor

Unset ID on 404 HTTP status codes in selvpc_resell_floatingip_v2, selvpc_resell_license_v2 and selvpc_resell_project_v2 resources.

Depends on #48, #52
For #47

@ozerovandrei
Copy link
Contributor Author

@bill-rich this is ready for review.

This PR depends on #48, #52.

@bill-rich bill-rich mentioned this pull request Oct 15, 2018
8 tasks
@ozerovandrei ozerovandrei force-pushed the fix/unset-id-for-nonexisting branch 3 times, most recently from ee741cc to 9d5347a Compare November 7, 2018 04:13
Copy link

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Unset ID on 404 HTTP response status code.
Unset ID on 404 HTTP response status code.
Unset ID on 404 HTTP response status code.
@ozerovandrei ozerovandrei merged commit 88a05de into master Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants