Skip to content

Reorder required attributes #54

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Reorder required attributes #54

merged 3 commits into from
Nov 13, 2018

Conversation

ozerovandrei
Copy link
Contributor

Move required attributes to the top of the selvpc_resell_floatingip_v2, selvpc_resell_license_v2 and selvpc_resell_project_v2 resources.

Depends on #48, #52, #53
For #47

@bill-rich bill-rich mentioned this pull request Oct 15, 2018
Closed
8 tasks
@ozerovandrei
Copy link
Contributor Author

@bill-rich this is ready for review.

This PR depends on #48, #52, #53.

@ozerovandrei ozerovandrei force-pushed the fix/reorder-attributes branch 3 times, most recently from 74d5986 to 2f386da Compare November 7, 2018 04:13
bill-rich
bill-rich approved these changes Nov 13, 2018
View reviewed changes
Copy link

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei
FloatingIPV2: reorder attributes
3c2b466 
Move required attributes to the top of the resourceResellFloatingIPV2.
@ozerovandrei
LicenseV2: reorder attributes
c7fe60d 
Move required attributes to the top of the resourceResellLicenseV2.
@ozerovandrei
ProjectV2: reorder attributes
7331be7 
Move required attributes to the top of the quotas scheme.
@ozerovandrei ozerovandrei merged commit 7029075 into master Nov 13, 2018
@ozerovandrei ozerovandrei deleted the fix/reorder-attributes branch November 13, 2018 22:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozerovandrei @bill-rich