Integrate new UID reference widget #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…senaite.core into new-uidreference-widget
…senaite.core into new-uidreference-widget
xispa
approved these changes
May 30, 2023
There was a problem hiding this comment.
Thanks for this astonishing work!. Plenty of things here. I've done functional testing and works as expected for reference fields and widgets from core.
@xispa , I've found a couple of fields/widgets of mine (e.g. UIDOtherReferenceField and UIDOtherReferenceWidget that require attention) before we can move custom add-ons forward with this change.
| return filter(lambda uid: uid, value) | ||
| if api.is_string(value): | ||
| value = value.split("\r\n") | ||
| return list(filter(None, value)) |
There was a problem hiding this comment.
I would do
return list(filter(api.is_uid, value))|
|
||
| # extract the assigned UIDs for multi-reference fields | ||
| if field.multiValued: | ||
| value = filter(None, value.split(",")) | ||
| value = filter(None, fieldvalue.split("\r\n")) |
There was a problem hiding this comment.
value = filter(api.is_uid, fieldvalue.split("\r\n"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR integrates the new DX compatible UID reference widget for all AT reference fields
Current behavior before PR
Old widget is used for AT reference fields
Desired behavior after PR is merged
New widget is used for AT reference fields
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.