Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Sample/Container Reference Fields to new Widget #37

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Dec 7, 2023

Description of the issue/feature this PR addresses

This PR migrates the used Combo Box widgets to the new UID Reference Widget to make the Add-on compatible with senaite/senaite.core#2295

Current behavior before PR

Storage Container / Sample selection does not work

Desired behavior after PR is merged

Storage Container / Sample selection works and uses the new UID Reference Widget

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added the bug Something isn't working label Dec 7, 2023
@ramonski ramonski requested a review from xispa December 7, 2023 11:52
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine, thanks!

@xispa xispa merged commit c6ff568 into 2.x Dec 8, 2023
@xispa xispa deleted the fix-uidreferencewidgets branch December 8, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants