Generate unique ID for DX types on object creation #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
changed the title
``` Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 385, in publish_module Module ZPublisher.WSGIPublisher, line 288, in publish Module ZPublisher.mapply, line 85, in mapply Module ZPublisher.WSGIPublisher, line 63, in call_object Module Products.CMFPlone.controlpanel.browser.quickinstaller, line 666, in __call__ Module Products.CMFPlone.controlpanel.browser.quickinstaller, line 399, in upgrade_product Module Products.GenericSetup.tool, line 1202, in upgradeProfile Module Products.GenericSetup.upgrade, line 185, in doStep Module senaite.core.upgrade, line 41, in wrap_func_args Module zope.event, line 33, in notify Module zope.component.event, line 27, in dispatch Module zope.component._api, line 134, in subscribers Module zope.interface.registry, line 448, in subscribers Module zope.interface.adapter, line 899, in subscribers Module senaite.storage.subscribers.upgrade, line 33, in afterUpgradeStepHandler Module senaite.storage.setuphandlers, line 222, in post_install Module senaite.storage.setuphandlers, line 316, in migrate_storage_locations Module bika.lims.api, line 859, in search Module Products.CMFPlone.CatalogTool, line 440, in searchResults Module Products.CMFCore.indexing, line 97, in processQueue Module Products.CMFCore.indexing, line 227, in process Module senaite.core.patches.catalog, line 110, in portal_catalog_reindex Module senaite.core.patches.catalog, line 93, in in_portal_catalog TypeError: argument of type 'NoneType' is not iterable ```
xispa
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR is related to #2370 and #2368 to create the right ID during object creation.
This avoids also the time consuming process of moving the whole object when renamed afterwards and should therefore increase the performance.
Current behavior before PR
AT and DX contents are renamed after creation
Desired behavior after PR is merged
A correct ID for AT and DX contents is generated during the creation process.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.