Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports for moved idserver module #2377

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix imports for moved idserver module #2377

merged 2 commits into from
Sep 6, 2023

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Sep 5, 2023

Description of the issue/feature this PR addresses

This PR is releavant #2372 and fixes the imports to renameAfterCreation to avoid deprecation warnings.

Current behavior before PR

This import is used:
from bika.lims.idserver import renameAfterCreation

Desired behavior after PR is merged

This import is used:
from senaite.core.idserver import renameAfterCreation

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added the Cleanup 🧹 Code cleanup and refactoring label Sep 5, 2023
@ramonski ramonski requested a review from xispa September 5, 2023 20:44
@xispa xispa merged commit 81ca2a8 into 2.x Sep 6, 2023
2 checks passed
@xispa xispa deleted the fix-imports-for-idserver branch September 6, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring
Development

Successfully merging this pull request may close these issues.

2 participants