The following changes relate to use in a non-composer environment: #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing file extension for `/mail/BatchId` in `loader.php` * Re-order requires to ensure `EmailAddress` is loaded before `Bcc` (`Bcc` depends on `EmailAddress` being loaded) * Change `README.md` to reference `./lib/loader.php` instead of `./sendgrid-php.php` for non-composer use. * Change example documentation to reference the required HTTP library dependency and how to install it without composer
thinkingserious
added
the
status: code review request
|
Ah, it looks like you got it all sorted out after all! :) I've added this to our backlog for a code review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Checklist
Short description of what this PR does:
The following changes relate to use in a non-composer environment:
/mail/BatchIdinloader.phpEmailAddressis loaded beforeBcc(Bccdepends onEmailAddressbeing loaded)README.mdto reference./lib/loader.phpinstead of./sendgrid-php.phpfor non-composer use.NOTE: It is likely that the
usecommands in https://github.com/sendgrid/sendgrid-php/blob/master/USE_CASES.md#transactional-templates can be removed as well.