Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing file extension #634

Closed
wants to merge 1 commit into from
Closed

missing file extension #634

wants to merge 1 commit into from

Conversation

muberraduman
Copy link

the extension was missing for /mail/BatchId.php

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@muberraduman
missing file extension
d920a46 
the extension was missing for /mail/BatchId.php
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 28, 2018
@SendGridDX
Copy link

SendGridDX commented Jun 28, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty labels Jul 3, 2018
@thinkingserious
Copy link
Contributor

Thank you @muberraduman! This has been added to our backlog.

@thinkingserious thinkingserious mentioned this pull request Jul 5, 2018
Closed
@thinkingserious thinkingserious added status: duplicate duplicate issue and removed difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library labels Aug 7, 2018
@thinkingserious
Copy link
Contributor

This was fixed with PR #633

We still appreciate that you took the time to help us out, so please fill out this form and we'll get some swag over to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: duplicate duplicate issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muberraduman @SendGridDX @thinkingserious