Skip to content

Commit

Permalink
fix: email is required (#457)
Browse files Browse the repository at this point in the history
  • Loading branch information
luk4s authored Jan 16, 2021
1 parent 90f50b5 commit 7d9a647
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/sendgrid/helpers/mail/email.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ module SendGrid
class Email
attr_accessor :email, :name

def initialize(email: nil, name: nil)
# @param [String] email required e-mail address
# @param [String] name optionally personification
def initialize(email:, name: nil)
if name
@email = email
@name = name
Expand All @@ -15,6 +17,8 @@ def initialize(email: nil, name: nil)

def split_email(email)
split = /(?:(?<address>.+)\s)?<?(?<email>.+@[^>]+)>?/.match(email)
raise ArgumentError, "email (#{email}) is invalid" unless split

[split[:email], split[:address]]
end

Expand Down
9 changes: 9 additions & 0 deletions test/sendgrid/helpers/mail/test_email.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,13 @@ def test_split_email_name_and_email
}
assert_equal @email.to_json, expected_json
end

def test_mandatory_email_missing
assert_raises(ArgumentError) { Email.new(email: nil) }
assert_raises(ArgumentError) { Email.new(email: "") }
end

def test_invalid_email
assert_raises(ArgumentError) { Email.new(email: "some-invalid-string") }
end
end

0 comments on commit 7d9a647

Please sign in to comment.