Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email is required #457

Merged
merged 3 commits into from
Jan 16, 2021
Merged

fix: email is required #457

merged 3 commits into from
Jan 16, 2021

Conversation

luk4s
Copy link
Contributor

@luk4s luk4s commented Jan 13, 2021

chore: SendGrid::Email mandatory email argument

class in constructor have definition email: nil but actually it can't work without "email". I think it can be confused. If I pass blank or invalid string there, it fail in split_email method => I suggest to raise ArgumentError with explanation instead.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 13, 2021
@eshanholtz eshanholtz changed the title Email is mandatory fix: email is required Jan 16, 2021
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@eshanholtz eshanholtz merged commit 7d9a647 into sendgrid:main Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants