Becoming the official plugin

[nfantone]

@disintegrator Some good news: we have been discussing with @geek and @mcdonnelldean (part of the Seneca core team) about making this plugin the official AMQP transport in detriment of seneca-rabbitmq-transport.

Are you willing to participate in this? We need to make a new release with the latest changes and plan some other things for the future.

[disintegrator]

Sounds good to me. Do you (or them) think there's anything more to do before we can take over? Are we missing some key features?

[nfantone]

@disintegrator I've asked them the same thing but didn't receive any feedback yet.

[disintegrator]

Brilliant I'll keep an eye on the thread. Meanwhile I'll jump in and help improve the library. We sorely need more docs and tests for the library to be taken seriously.

[nfantone]

Tests would be swell. It'd also be great if no RabbitMQ instance were needed for unit testing. I've seen some setup over at seneca-rabbitmq-transport that fires a rabbitmq docker before starting. I think that kind of functional/black box testing should be written separately. What are your thoughts?

While far from perfect, docs have improved quite a bit. Take a look at latest develop.

[nfantone]

@disintegrator When you have a moment, could you please release 0.2.0 to npm? Thank you.

[disintegrator]

@nfantone done!

[nfantone]

@disintegrator Thanks!

Could we please follow the guidelines for releasing a version, next time?

I've already tagged the repo for the 0.2.0 version.

[disintegrator]

Oh damn. Sorry I did it in a rush so I didn't block you. Will follow guidelines next time

[n321203]

Just wanted to say im really happy there is an actively developed amqp-plugin. 👍

[nfantone]

@n321203 Hey, thanks, man! I hope you find the plugin useful. And, of course, feel free to contribute back. Any help is appreciated.

[nfantone]

@disintegrator Would you please consider giving me npm publishing right? I've released and tagged 0.2.1 and I'd like to upload that.

[disintegrator]

Yep I'll look into it

Sent from my iPhone

On 23 Apr 2016, at 7:14 AM, Nicolás Fantone notifications@github.com wrote:

@disintegrator Would you please consider giving me npm publishing right? I've released and tagged 0.2.1 and I'd like to upload that.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[nfantone]

@disintegrator https://docs.npmjs.com/cli/owner

[luhtonen]

Any news on the discussion with seneca owners to make this official? Are there concrete plans and dates setup/agreed?

[nfantone]

@luhtonen That's a good question. Doors have been opened for quite a while now. I'm all for it. Not much to do from my end, TBH. I'm waiting for the guys at Seneca to give me the heads up. AFAIK, they have been working hard to accommodate things and put together a more cohesive plugin ecosystem, lately.

[nfantone]

@mcdonnelldean So... any changes so far? Are you guys ready for this? 🎈

[mcdonnelldean]

@nfantone Yes, sorry, as usual we are bogged down. I spoke to Richard and others about green lighting. Rather than wait for the official procession lets just get it done :D

Can you add me repo so I can move it into senecajs/ org? You will need to republish after to fix npm links. Note it will go into the same org as seneca proper, not the labs or community org.

The only rules really are to try keep a cohesive linting and tooling standard and to keep the project MIT. Usual stuff.

[nfantone]

Yey 🎂 ! Finally.

Well, repo already uses Seneca's eslint rules, is MIT licensed and follows your contributing guide.

If you need any further changes, let me know.

[nfantone]

@mcdonnelldean Invite already sent. Check your inbox.

[mcdonnelldean]

Yup got it. Should be moved in the next couple of hours

On 11 Oct 2016 6:21 p.m., "Nicolás Fantone" notifications@github.com
wrote:

@mcdonnelldean https://github.com/mcdonnelldean Invite already sent.
Check your inbox.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADdT6abT2ZBJA_R1LjgFn3FXxOkwJkWZks5qy8WlgaJpZM4HJe7X
.

[nfantone]

@mcdonnelldean I don't know if you have already established some guidelines for these migrations, but one approach we have been following with Koa modules is to drop the koa- prefix on repo's names once moved onto the organization. If it's in our repo, that becomes tacit. So, for Seneca, that would make:

https://github.com/seneca-contrib/seneca-amqp-transport -> https://github.com/senecajs/amqp-transport

[mcdonnelldean]

Generally we leave it as is, we find the seneca-x way makes it easier to find things on github and npm. Should be moved in two mins.

[mcdonnelldean]

@nfantone Looks like I need to be bumped to owner to move it across. Once done ping and I'll move. (write privilege is not enough)

[nfantone]

I believe I made you Admin of the repo. Let me check.

[nfantone]

@mcdonnelldean Yup. Your rank is as high as they come.

[mcdonnelldean]

Testing, testing... Are we live, has everyone got the right access?

[nfantone]

@mcdonnelldean Seems like it.

👀 Everyone all right?

[nfantone]

@mcdonnelldean Tried pulling and pushing. Works wonders.

One thing, though: do we have a team that maybe I can become a member of? This is just to show a "badge" on issues to tell people I'm maintaining the project. It used to be "seneca-contrib member" previously.

[mcdonnelldean]

Yup, I'm setting it all up now, you will end up on two or three but it always shows you are a member then.

[mcdonnelldean]

Ok I've sent the contributors one only so it doesn't go all funny from multiple requests. You should see the info here https://github.com/orgs/senecajs/teams/contributors.

[nfantone]

404 on that URL. I suppose I don't have access to that yet.

[mcdonnelldean]

Really? Can you hit the teams page and then contributors? Your invite pops
up there too

On 11 Oct 2016 8:30 p.m., "Nicolás Fantone" notifications@github.com
wrote:

404 on that URL. I suppose I don't have access to that yet.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADdT6YihBjOpFDUj6WCZ6FaRj3NnHuGkks5qy-PjgaJpZM4HJe7X
.

[mcdonnelldean]

Maybe try just https://github.com/senecajs It should pop up there.

[nfantone]

There. Invitation arrived. All set, then.

Thank you very much for letting me on board!

I'll be closing the issue.

[mcdonnelldean]

Yay! Cc @rjrodger @paolochiodi

On 11 Oct 2016 8:39 p.m., "Nicolás Fantone" notifications@github.com
wrote:

Closed #6 #6.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADdT6fFo4NcvQnYzHyxGSGGWd4dg-nntks5qy-YJgaJpZM4HJe7X
.