-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release #10
New release #10
Conversation
Add "rabbitmq" keyword
@nfantone set the default branch to develop and set master to protected |
@nfantone skimming through the guidelines, I don't see anything that we are falling short on besides tagging of npm releases |
Well... What about labels for issues? If I recall correctly, ours don't
|
I just checked the issues and so far we use bug, question and request (I just added it). These are all listed on the guideline page. I have also tagged the closed issues with the most appropriate labels I can pick. |
I'd like to have the "discussion" label. #6, for instance, could be labeled as such. What do you think? |
Thank you very much for that. |
Added discussion label to #6 |
👍 Great |
Enhance multiple client/listeners declarations Delegate queue and topic generations to common module
Support for multiple pins
@disintegrator Many more features added, including multi-pin support, custom queue naming and pre-commit hooks for lint validations. |
Amazing work @nfantone. |
If you don't have permission to merge this PR, let me know when you'd like me to do it |
@disintegrator I do have permission. But it's your project, really. And, besides, I'd like someone to, at least, do a sanity check on all the crap I'm pushing. What I wouldn't be able to do is publish to npm. So, there's that. Apart from those things, you can merge this PR whenever you want. |
Thanks, man. You don't really need to, though. Seriously. |
Any movement here? My team is really excited to use these changes, but would very prefer a public release to npm over a development snapshot. Is there anything I/We can do to help? |
@cicavey Merged. @disintegrator will need to push this to npm, though. Sorry for the lack of response. |
Wow. Didn't expect that kind of turnaround. Thanks! |
@cicavey Released to |
We should merge and publish all these new features, releasing as
0.2.0
to npm.@disintegrator Could you, please, also:
develop
the default branch. If you clone the repo, let's assume you want to collaborate and push some code. If you fork, it should also be from that branch.master
branch.0.2.0
release before publishing to npm.Thanks!