Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #10

Merged
merged 21 commits into from
Feb 16, 2016
Merged

New release #10

merged 21 commits into from
Feb 16, 2016

Conversation

nfantone
Copy link
Collaborator

We should merge and publish all these new features, releasing as 0.2.0 to npm.

@disintegrator Could you, please, also:

  • Make develop the default branch. If you clone the repo, let's assume you want to collaborate and push some code. If you fork, it should also be from that branch.
  • Protect master branch.
  • Create a named tag for the 0.2.0 release before publishing to npm.
  • Take a look at the general Seneca repository guidelines and see if you can setup this repository to comply to them.

Thanks!

@nfantone nfantone added this to the 0.2.0 milestone Jan 29, 2016
@disintegrator
Copy link
Collaborator

@nfantone set the default branch to develop and set master to protected

@disintegrator
Copy link
Collaborator

@nfantone skimming through the guidelines, I don't see anything that we are falling short on besides tagging of npm releases

@nfantone
Copy link
Collaborator Author

Well... What about labels for issues? If I recall correctly, ours don't
exactly match with the ones proposed by the guide.
On Jan 31, 2016 7:55 PM, "George Haidar" notifications@github.com wrote:

@nfantone https://github.com/nfantone skimming through the guidelines,
I don't see anything that we are falling short on besides tagging of npm
releases


Reply to this email directly or view it on GitHub
#10 (comment)
.

@disintegrator
Copy link
Collaborator

I just checked the issues and so far we use bug, question and request (I just added it). These are all listed on the guideline page. I have also tagged the closed issues with the most appropriate labels I can pick.

@nfantone
Copy link
Collaborator Author

I'd like to have the "discussion" label. #6, for instance, could be labeled as such. What do you think?

@nfantone
Copy link
Collaborator Author

set the default branch to develop and set master to protected

Thank you very much for that.

@disintegrator
Copy link
Collaborator

Added discussion label to #6

@nfantone
Copy link
Collaborator Author

👍 Great

@nfantone
Copy link
Collaborator Author

nfantone commented Feb 2, 2016

@disintegrator Many more features added, including multi-pin support, custom queue naming and pre-commit hooks for lint validations.

@disintegrator
Copy link
Collaborator

Amazing work @nfantone.
As an aside: When I have a sec, I'll move this project to an organisation to make sure you are getting recognised for your contributions.

@disintegrator
Copy link
Collaborator

If you don't have permission to merge this PR, let me know when you'd like me to do it

@nfantone
Copy link
Collaborator Author

nfantone commented Feb 3, 2016

@disintegrator I do have permission. But it's your project, really. And, besides, I'd like someone to, at least, do a sanity check on all the crap I'm pushing.

What I wouldn't be able to do is publish to npm. So, there's that.

Apart from those things, you can merge this PR whenever you want.

@nfantone
Copy link
Collaborator Author

nfantone commented Feb 3, 2016

I'll move this project to an organisation to make sure you are getting recognised for your contributions.

Thanks, man. You don't really need to, though. Seriously.

@cicavey
Copy link

cicavey commented Feb 16, 2016

Any movement here? My team is really excited to use these changes, but would very prefer a public release to npm over a development snapshot. Is there anything I/We can do to help?

nfantone added a commit that referenced this pull request Feb 16, 2016
@nfantone nfantone merged commit 476d318 into master Feb 16, 2016
@nfantone
Copy link
Collaborator Author

@cicavey Merged. @disintegrator will need to push this to npm, though. Sorry for the lack of response.

@cicavey
Copy link

cicavey commented Feb 16, 2016

Wow. Didn't expect that kind of turnaround. Thanks!

@nfantone
Copy link
Collaborator Author

@cicavey Released to npm under 0.2.0 tag.

https://www.npmjs.com/package/seneca-amqp-transport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants