Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream 4.0.4 #6

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Merge upstream 4.0.4 #6

merged 14 commits into from
Dec 7, 2023

Conversation

Kaapp
Copy link

@Kaapp Kaapp commented Dec 6, 2023

Update to 4.0.4 so we can remove these awkward (but harmless) console errors.

Once this is merged I can re-pack and make a PR to update the platform.

Same process as before:

git remote add upstream git@github.com:visgl/loaders.gl.git
git fetch upstream
git merge --no-ff v4.0.4
# no merge conflicts this time
yarn install
yarn build
git commit # although did this via Github Desktop
git push -u origin merge-4.0.4-master

BEFORE:
image

AFTER:
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7118674162

  • 781 of 1018 (76.72%) changed or added relevant lines in 122 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 67.489%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/arrow/src/parsers/parse-geoarrow-sync.ts 21 22 95.45%
modules/arrow/src/workers/arrow-worker.ts 0 1 0.0%
modules/worker-utils/src/lib/worker-farm/worker-body.ts 22 23 95.65%
modules/arrow/src/geoarrow/convert-geoarrow-to-geojson.ts 4 6 66.67%
modules/terrain/src/workers/quantized-mesh-worker.ts 0 3 0.0%
modules/terrain/src/workers/terrain-worker.ts 0 3 0.0%
modules/textures/src/lib/encoders/encode-ktx.ts 0 3 0.0%
modules/textures/src/lib/parsers/parse-crunch.ts 0 3 0.0%
modules/textures/src/workers/basis-worker.ts 0 3 0.0%
modules/textures/src/workers/compressed-texture-worker.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 6973105739: 0.08%
Covered Lines: 69156
Relevant Lines: 103704

💛 - Coveralls

@Kaapp Kaapp merged commit 38c6dd6 into master Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants