getChildResults(): reduce the amount of invocation of getResult() met…

…hod (#3396)
serenity-bdd · Feb 5, 2024 · 573bf3c · 573bf3c
1 parent 762c257
commit 573bf3c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/serenity-model/src/main/java/net/thucydides/model/domain/TestStep.java b/serenity-model/src/main/java/net/thucydides/model/domain/TestStep.java
@@ -491,12 +491,14 @@ private TestResult getResultFromChildren() {
         return TestResultList.overallResultFrom(getChildResults());
     }
 
-
     private List<TestResult> getChildResults() {
         List<TestResult> childResults = new ArrayList<>();
         for (TestStep step : getChildren()) {
-            if (step != null && step.getResult() != null) {
-                childResults.add(step.getResult());
+            if (step != null) {
+                TestResult stepResult = step.getResult();
+                if (stepResult != null) {
+                    childResults.add(stepResult);
+                }
             }
         }
         return childResults;