Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TestStep - optimize method to obtain result #3396

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

oleg-rd
Copy link
Contributor

@oleg-rd oleg-rd commented Feb 5, 2024

For the cases when TestStep has nested steps (=children), getChildResults() will be invoked in order to calculate the final result. It will be done for every node, that has children itself. However, with the current implementation amount of those calls is enormous.

Let's imagine following case, when there is 3 level of nested steps:

TestStep parentStep = new TestStep("Test Step: Level 0");
int level = 3;
TestStep currentStep = parentStep;
for (int i = 1; i <= level; i++) {
    TestStep childStep = new TestStep("Test Step: Level "+ i);
    currentStep.addChildStep(childStep);
    currentStep = childStep;
}

With current implementation call to getResult() method would produce the output like (debug output was added for demonstration purposes):

Get result for step on level: 0
Get child results for step on level: 0
	Get result for step on level: 1
	Get child results for step on level: 1
		Get result for step on level: 2
		Get child results for step on level: 2
			Get result for step on level: 3
			Get result for step on level: 3
		Get result for step on level: 2
		Get child results for step on level: 2
			Get result for step on level: 3
			Get result for step on level: 3
	Get result for step on level: 1
	Get child results for step on level: 1
		Get result for step on level: 2
		Get child results for step on level: 2
			Get result for step on level: 3
			Get result for step on level: 3
		Get result for step on level: 2
		Get child results for step on level: 2
			Get result for step on level: 3
			Get result for step on level: 3

With updated version, it will be like that:

Get result for step on level: 0
Get child results for step on level: 0
	Get result for step on level: 1
	Get child results for step on level: 1
		Get result for step on level: 2
		Get child results for step on level: 2
			Get result for step on level: 3		

I'm not sure if this behavior might be covered with unit tests.

@wakaleo wakaleo merged commit 573bf3c into serenity-bdd:main Feb 5, 2024
1 check passed
@oleg-rd oleg-rd deleted the optimize_get_result branch February 5, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants