fix: TestStep - optimize method to obtain result #3396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the cases when TestStep has nested steps (=children),
getChildResults(
) will be invoked in order to calculate the final result. It will be done for every node, that has children itself. However, with the current implementation amount of those calls is enormous.Let's imagine following case, when there is 3 level of nested steps:
With current implementation call to
getResult()
method would produce the output like (debug output was added for demonstration purposes):With updated version, it will be like that:
I'm not sure if this behavior might be covered with unit tests.