-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Box big model type fields #2205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
Related to Serenity's examples.
model
Related to the `model` module.
utils
Related to the `utils` module.
labels
Oct 3, 2022
As JellyWX smartly noted: > Boxing CommandData seems an odd choice considering this is probably going to be accessed a lot of the time that it is present. My understanding is that heap lookups are slower, but I don't know by how much? https://discord.com/channels/381880193251409931/673965002805477386/1026528518445744188
kangalio
force-pushed
the
box-big-fields
branch
from
October 8, 2022 08:51
8795499
to
30d536d
Compare
arqunis
added
enhancement
An improvement to Serenity.
breaking change
The public API is changed, resulting in miscompilations or unexpected new behaviour for users
labels
Oct 8, 2022
arqunis
approved these changes
Oct 8, 2022
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 7, 2022
This helps reduce the stack size of most types.
arqunis
pushed a commit
that referenced
this pull request
Nov 13, 2022
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
This helps reduce the stack size of most types.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
This helps reduce the stack size of most types.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
This helps reduce the stack size of most types.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
This helps reduce the stack size of most types.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
This helps reduce the stack size of most types.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
This helps reduce the stack size of most types.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
This helps reduce the stack size of most types.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
This helps reduce the stack size of most types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
The public API is changed, resulting in miscompilations or unexpected new behaviour for users
enhancement
An improvement to Serenity.
examples
Related to Serenity's examples.
model
Related to the `model` module.
utils
Related to the `utils` module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Guild unfortunately cannot reasonably be shrunken by just boxing its fields because it just contains a huge amount of small fields (HashMap takes 48 bytes each, Vec/String 24 bytes each).