Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing forum fields to guild channel #2298

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

Chronophylos
Copy link
Contributor

Added flags, total_messages_sent, available_tags, applied_tags, default_reaction_emoji, default_thread_rate_limit_per_user and default_sort_order fields to GuildChannel.
Added ForumTag, ForumTagId, DefaultReaction, and SortOrder objects.
Boxed the Channel::Guild variant to reduce the enum size.

@github-actions github-actions bot added cache Related to the `cache`-feature. model Related to the `model` module. utils Related to the `utils` module. labels Nov 22, 2022
Added `flags`, `total_messages_sent`, `available_tags`, `applied_tags`,
`default_reaction_emoji`, `default_thread_rate_limit_per_user` and
`default_sort_order` fields to `GuildChannel`.
Added `ForumTag`, `ForumTagId`, `DefaultReaction` and `SortOrder`
objects.
Box the `Channel::Guild` variant to reduce enum size.
@arqunis
Copy link
Member

arqunis commented Nov 26, 2022

Boxed the Channel::Guild variant to reduce the enum size.

This is a breaking change. You'll have to either remove this change, or rebase the PR to the next branch.

@arqunis arqunis added enhancement An improvement to Serenity. discord feature Related to Discord's functionality. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Nov 26, 2022
Copy link
Member

@arqunis arqunis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine otherwise.

@kangalio
Copy link
Collaborator

Boxing has already been done in #2205 so it can be safely removed from this PR

@arqunis arqunis merged commit 6d82cf2 into serenity-rs:current Dec 4, 2022
@BrettMayson
Copy link

This seems to have broken Interaction::MessageComponent. I am getting this error when clicking on a button on a message, the handler is not ran.

WARN run:recv_event:handle_event{event=Err(Json(Error("event InteractionCreate: missing field `available_tags`", line: 0, column: 0)))}: serenity::gateway::shard: [Shard [0, 1]] Unhandled error: Json(Error("event InteractionCreate: missing field `available_tags`", line: 0, column: 0))

@arqunis
Copy link
Member

arqunis commented Dec 11, 2022

This seems to have broken Interaction::MessageComponent. I am getting this error when clicking on a button on a message, the handler is not ran.

WARN run:recv_event:handle_event{event=Err(Json(Error("event InteractionCreate: missing field `available_tags`", line: 0, column: 0)))}: serenity::gateway::shard: [Shard [0, 1]] Unhandled error: Json(Error("event InteractionCreate: missing field `available_tags`", line: 0, column: 0))

This should be fixed with fc9c420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. discord feature Related to Discord's functionality. enhancement An improvement to Serenity. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants