Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Remix v2 #243

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

roger-tbg
Copy link
Contributor

changed package-json version to 3.6.0
updated remix* packages to 2.x and 18.x

changed package-json version to 3.6.0
Make these deps || to prevent breaking change/major version bump
Copy link
Owner

@sergiodxa sergiodxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just one comment to revert the version on package.json, a GitHub Action bump that and create a Git tag for the version.

Allow Github Action to change version number
@sergiodxa sergiodxa changed the title update to remix 2.x Add support for Remix v2 Sep 26, 2023
@sergiodxa sergiodxa added the enhancement New feature or request label Sep 26, 2023
@sergiodxa sergiodxa self-assigned this Sep 26, 2023
@sergiodxa sergiodxa merged commit af28b2a into sergiodxa:main Sep 26, 2023
@Soleone
Copy link

Soleone commented Sep 26, 2023

I'm on the edge of my seat watching 3.6.0 make it into production so I can npm install remix-auth in my Remix2 project 🤞

@Soleone
Copy link

Soleone commented Sep 27, 2023

Fixes #242

@roger-tbg roger-tbg deleted the update-version branch September 28, 2023 12:07
@wolthers
Copy link

Any idea when this will be released? :)

@sergiodxa
Copy link
Owner

When I have time to fix CI not working here, or someone makes a PR.

@aydrian
Copy link
Contributor

aydrian commented Sep 30, 2023

When I have time to fix CI not working here, or someone makes a PR.

Hey @sergiodxa, I'm almost finished with a PR to resolve the CI issues. I'll push it either today or tomorrow. I'm currently only updating the dependencies required to fix the issues. Would you like me to also bump the others? The way things are working right now, we are only testing against the 2.x version of Remix. I can follow up with 1.x testing using environments afterward if you think it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants