Resolved CI Linter and Unit and Integration Tests failures #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/parser to latest version to resolve lint errors
sergiodxa
approved these changes
Sep 30, 2023
|
I noticed the CI failed again. Could this be due to it running Node v14? |
|
Added PR #247 to hopefully resolve the remaining issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should unblock release for #243
I only upgraded the dependencies required to resolve the issues. I updated
@remix-run/server-runtimeto^2.0.1, this required me to upgrade Jest in order to handlenode:cryptono longer being polyfilled in@remix-run/node. The url passed to new Requests in tests had to be updated to fit new validation. I also had to change the way we test thrown responses due to the returned object not deeply matching anymore. Now instead checking to make sure error thrown is an instance of Response and then checking that the status and message are what's expected.